Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37761 )
Change subject: mb/google/rambi: add VBTs for variants ......................................................................
mb/google/rambi: add VBTs for variants
Add VBTs for all rambi variants, extracted from VGA BIOS from stock firmware images using intelvbttool.
Test: boot several rambi variants using MrChromebox edk2/master branch with Baytrail GOP driver and extracted VBTs.
Change-Id: I401ae5accd852fc5211092a5944fc85871b642ae Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/rambi/Kconfig A src/mainboard/google/rambi/variants/banjo/data.vbt A src/mainboard/google/rambi/variants/candy/data.vbt A src/mainboard/google/rambi/variants/clapper/data.vbt A src/mainboard/google/rambi/variants/enguarde/data.vbt A src/mainboard/google/rambi/variants/glimmer/data.vbt A src/mainboard/google/rambi/variants/gnawty/data.vbt A src/mainboard/google/rambi/variants/heli/data.vbt A src/mainboard/google/rambi/variants/kip/data.vbt A src/mainboard/google/rambi/variants/ninja/data.vbt A src/mainboard/google/rambi/variants/orco/data.vbt A src/mainboard/google/rambi/variants/quawks/data.vbt A src/mainboard/google/rambi/variants/squawks/data.vbt A src/mainboard/google/rambi/variants/sumo/data.vbt A src/mainboard/google/rambi/variants/swanky/data.vbt A src/mainboard/google/rambi/variants/winky/data.vbt 16 files changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/37761/1
diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index fc6e28e..7a23a7d 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -9,6 +9,7 @@ select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME + select INTEL_GMA_HAVE_VBT if !BOARD_GOOGLE_RAMBI select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 diff --git a/src/mainboard/google/rambi/variants/banjo/data.vbt b/src/mainboard/google/rambi/variants/banjo/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/banjo/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/candy/data.vbt b/src/mainboard/google/rambi/variants/candy/data.vbt new file mode 100644 index 0000000..0b76491 --- /dev/null +++ b/src/mainboard/google/rambi/variants/candy/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/clapper/data.vbt b/src/mainboard/google/rambi/variants/clapper/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/clapper/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/enguarde/data.vbt b/src/mainboard/google/rambi/variants/enguarde/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/enguarde/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/glimmer/data.vbt b/src/mainboard/google/rambi/variants/glimmer/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/glimmer/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/gnawty/data.vbt b/src/mainboard/google/rambi/variants/gnawty/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/gnawty/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/heli/data.vbt b/src/mainboard/google/rambi/variants/heli/data.vbt new file mode 100644 index 0000000..0b76491 --- /dev/null +++ b/src/mainboard/google/rambi/variants/heli/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/kip/data.vbt b/src/mainboard/google/rambi/variants/kip/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/kip/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/ninja/data.vbt b/src/mainboard/google/rambi/variants/ninja/data.vbt new file mode 100644 index 0000000..1971ebb --- /dev/null +++ b/src/mainboard/google/rambi/variants/ninja/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/orco/data.vbt b/src/mainboard/google/rambi/variants/orco/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/orco/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/quawks/data.vbt b/src/mainboard/google/rambi/variants/quawks/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/quawks/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/squawks/data.vbt b/src/mainboard/google/rambi/variants/squawks/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/squawks/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/sumo/data.vbt b/src/mainboard/google/rambi/variants/sumo/data.vbt new file mode 100644 index 0000000..51cc56b --- /dev/null +++ b/src/mainboard/google/rambi/variants/sumo/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/swanky/data.vbt b/src/mainboard/google/rambi/variants/swanky/data.vbt new file mode 100644 index 0000000..d299aa4 --- /dev/null +++ b/src/mainboard/google/rambi/variants/swanky/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/winky/data.vbt b/src/mainboard/google/rambi/variants/winky/data.vbt new file mode 100644 index 0000000..55fa91a --- /dev/null +++ b/src/mainboard/google/rambi/variants/winky/data.vbt Binary files differ
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37761 )
Change subject: mb/google/rambi: add VBTs for variants ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37761 )
Change subject: mb/google/rambi: add VBTs for variants ......................................................................
mb/google/rambi: add VBTs for variants
Add VBTs for all rambi variants, extracted from VGA BIOS from stock firmware images using intelvbttool.
Test: boot several rambi variants using MrChromebox edk2/master branch with Baytrail GOP driver and extracted VBTs.
Change-Id: I401ae5accd852fc5211092a5944fc85871b642ae Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37761 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/mainboard/google/rambi/Kconfig A src/mainboard/google/rambi/variants/banjo/data.vbt A src/mainboard/google/rambi/variants/candy/data.vbt A src/mainboard/google/rambi/variants/clapper/data.vbt A src/mainboard/google/rambi/variants/enguarde/data.vbt A src/mainboard/google/rambi/variants/glimmer/data.vbt A src/mainboard/google/rambi/variants/gnawty/data.vbt A src/mainboard/google/rambi/variants/heli/data.vbt A src/mainboard/google/rambi/variants/kip/data.vbt A src/mainboard/google/rambi/variants/ninja/data.vbt A src/mainboard/google/rambi/variants/orco/data.vbt A src/mainboard/google/rambi/variants/quawks/data.vbt A src/mainboard/google/rambi/variants/squawks/data.vbt A src/mainboard/google/rambi/variants/sumo/data.vbt A src/mainboard/google/rambi/variants/swanky/data.vbt A src/mainboard/google/rambi/variants/winky/data.vbt 16 files changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/google/rambi/Kconfig b/src/mainboard/google/rambi/Kconfig index fc6e28e..7a23a7d 100644 --- a/src/mainboard/google/rambi/Kconfig +++ b/src/mainboard/google/rambi/Kconfig @@ -9,6 +9,7 @@ select HAVE_ACPI_TABLES select HAVE_OPTION_TABLE select HAVE_ACPI_RESUME + select INTEL_GMA_HAVE_VBT if !BOARD_GOOGLE_RAMBI select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_LPC_TPM select MAINBOARD_HAS_TPM1 diff --git a/src/mainboard/google/rambi/variants/banjo/data.vbt b/src/mainboard/google/rambi/variants/banjo/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/banjo/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/candy/data.vbt b/src/mainboard/google/rambi/variants/candy/data.vbt new file mode 100644 index 0000000..0b76491 --- /dev/null +++ b/src/mainboard/google/rambi/variants/candy/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/clapper/data.vbt b/src/mainboard/google/rambi/variants/clapper/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/clapper/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/enguarde/data.vbt b/src/mainboard/google/rambi/variants/enguarde/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/enguarde/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/glimmer/data.vbt b/src/mainboard/google/rambi/variants/glimmer/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/glimmer/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/gnawty/data.vbt b/src/mainboard/google/rambi/variants/gnawty/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/gnawty/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/heli/data.vbt b/src/mainboard/google/rambi/variants/heli/data.vbt new file mode 100644 index 0000000..0b76491 --- /dev/null +++ b/src/mainboard/google/rambi/variants/heli/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/kip/data.vbt b/src/mainboard/google/rambi/variants/kip/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/kip/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/ninja/data.vbt b/src/mainboard/google/rambi/variants/ninja/data.vbt new file mode 100644 index 0000000..1971ebb --- /dev/null +++ b/src/mainboard/google/rambi/variants/ninja/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/orco/data.vbt b/src/mainboard/google/rambi/variants/orco/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/orco/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/quawks/data.vbt b/src/mainboard/google/rambi/variants/quawks/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/quawks/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/squawks/data.vbt b/src/mainboard/google/rambi/variants/squawks/data.vbt new file mode 100644 index 0000000..01249f1 --- /dev/null +++ b/src/mainboard/google/rambi/variants/squawks/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/sumo/data.vbt b/src/mainboard/google/rambi/variants/sumo/data.vbt new file mode 100644 index 0000000..51cc56b --- /dev/null +++ b/src/mainboard/google/rambi/variants/sumo/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/swanky/data.vbt b/src/mainboard/google/rambi/variants/swanky/data.vbt new file mode 100644 index 0000000..d299aa4 --- /dev/null +++ b/src/mainboard/google/rambi/variants/swanky/data.vbt Binary files differ diff --git a/src/mainboard/google/rambi/variants/winky/data.vbt b/src/mainboard/google/rambi/variants/winky/data.vbt new file mode 100644 index 0000000..55fa91a --- /dev/null +++ b/src/mainboard/google/rambi/variants/winky/data.vbt Binary files differ
-
Matt DeVillier (Code Review) -
Nico Huber (Code Review)