Attention is currently required from: Patrick Georgi, Jonathan Zhang, ron minnich, Angel Pons, Arthur Heymans, Nathaniel L Desimone, Johnny Lin, Daocheng Bu, David Hendricks, Christian Walter, Srinidhi N Kaushik, Felix Held, Isaac W Oram.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75314 )
Change subject: vc/intel/fsp/fsp2_0/sapphirerapids_sp: Update Intel license header
......................................................................
Patch Set 1: Code-Review-1
(3 comments)
Patchset:
PS1:
Done. […]
The description of +1 literally states "someone else must approve".
Also, what was requested in CB:71948 was
"[...] an Intel-authored commit that changes the license for these files
to BSD-L like the others, including a notice that the license applies
retroactively."
PS1:
The license header was provided by Intel, also the same header can be referenced in change […]
That's about hobs_memmap.h which only covers <10% of this change.
PS1:
Please handle license matters with more care.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75314
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I31d0d309134ce66593d364c67bf5c2a294724d8b
Gerrit-Change-Number: 75314
Gerrit-PatchSet: 1
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Daocheng Bu
daocheng.bu@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Isaac W Oram
isaac.w.oram@intel.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
Gerrit-Attention: Patrick Georgi
patrick@coreboot.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: ron minnich
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Daocheng Bu
daocheng.bu@intel.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Isaac W Oram
isaac.w.oram@intel.com
Gerrit-Comment-Date: Thu, 18 May 2023 15:26:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment