Change in coreboot[master]: mb/google/octopus/variants/garg: update new SKU - coreboot-gerrit

26 Dec 2019


      Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37923 )
Change subject: mb/google/octopus/variants/garg: update new SKU
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37923/3/src/mainboard/google/octopu... 
File src/mainboard/google/octopus/variants/garg/include/variant/sku.h:
https://review.coreboot.org/c/coreboot/+/37923/3/src/mainboard/google/octopu... 
PS3, Line 27: 	SKU_38_2A2C_360_TS_NO_STYLUES = 38,
Which devices have a stylus, and which don't?
Please fix the spelling here to use stylus, not stylues.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/37923
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic74ce14db7060f3124c1a277eb3625ce0ff0b9f0
Gerrit-Change-Number: 37923
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Henry Sun henrysun@google.com
Gerrit-Reviewer: Justin TerAvest teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Kevin Chiu Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Marco Chen marcochen@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Justin TerAvest teravest@chromium.org
Gerrit-Comment-Date: Thu, 26 Dec 2019 16:01:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment