Attention is currently required from: Mac Chiang, Subrata Banik.
Kapil Porwal has posted comments on this change by Mac Chiang. ( https://review.coreboot.org/c/coreboot/+/86699?usp=email )
Change subject: mb/google/fatcat/var/francka: Add support for DMIC0 ......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/fatcat/variants/francka/fw_config.c:
https://review.coreboot.org/c/coreboot/+/86699/comment/36b71123_7692a640?usp... : PS6, Line 28: /* GPP_D09: PCH_DGPU_HOLD_RST#_R */ : PAD_NC(GPP_D09, NONE), : /* GPP_D16: HDA_RST# */ : PAD_NC(GPP_D16, NONE), : /* GPP_S00: SNDW_3_SCL */ : PAD_NC(GPP_S00, NONE), : /* GPP_S01: SNDW_3_SDA */ : PAD_NC(GPP_S01, NONE), : /* GPP_S04: SNDW2_CLK */ : PAD_NC(GPP_S04, NONE), : /* GPP_S05: SNDW2_DATA0 */ : PAD_NC(GPP_S05, NONE),
For future SoundWire SKUs, I think it will need to be reconfigured if set to default.
Yes but that needs to be handled separately. Currently we can move these GPIOs to gpio.c and later we can define a list of GPIO configuration needed for a sound wire in this file.
Note: `gpio_padbased_override` doesn't write to GPIO config registers hence there will be no reconfiguration involved.