Attention is currently required from: Furquan Shaikh, Matt DeVillier, Jeremy Soller, Angel Pons, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56008 )
Change subject: cannonlake mainboards: Set PMC as hidden in devicetree
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I wonder if we should set it for P2SB, too, then
```
src/mainboard/ocp/tiogapass/devicetree.cb: device pci 1f.1 hidden end # p2sb
```
tiogapass apparently does!
The purpose would be if you have device callbacks you still want for the P2SB even though it's not enumerated
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56008
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a20ce9075ce7653388a5d3e281fe774bf89355
Gerrit-Change-Number: 56008
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 07 Jul 2021 22:19:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment