Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86650?usp=email )
Change subject: mb/starlabs/starbook/mtl: Don't reconfigure GPIOs in ramstage ......................................................................
mb/starlabs/starbook/mtl: Don't reconfigure GPIOs in ramstage
GPP_H08 and GPP_H09 are configured in the bootblock, so remove the configuration in ramstage to allow the serial output in ramstage.
Change-Id: I4b813370cf259fb1ca138dd1922c16f801b40cc4 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86650 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/starbook/variants/mtl/gpio.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index f951094..7a8e660 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -267,10 +267,6 @@ PAD_NC(GPP_H06, NONE), /* H07: M.2_CPU_SSD_PWREN */ PAD_CFG_GPO(GPP_H07, 1, DEEP), - /* H08: */ - PAD_NC(GPP_H08, NONE), - /* H09: */ - PAD_NC(GPP_H09, NONE), /* H10: */ PAD_NC(GPP_H10, NONE), /* H11: */