Attention is currently required from: Martin Roth, Paul Menzel, Angel Pons.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52031 )
Change subject: mb/google/dedede: add lalala variant
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/dedede/variants/lalala/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52031/comment/5ac8acd2_80f355bb
PS2, Line 11: TBD
Hm?
This was lifted from magalor.
https://review.coreboot.org/c/coreboot/+/52031/comment/ed4977d0_6e5690d5
PS2, Line 300: device pci 1c.7 on
nit: I'd move this device up, so that the dev. […]
I was following magolor. I think we can reorder everything in a separate change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52031
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2f7abb9637cd5a13ac896396781b19feb156c948
Gerrit-Change-Number: 52031
Gerrit-PatchSet: 2
Gerrit-Owner: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 05 Apr 2021 14:30:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment