Attention is currently required from: Tim Crawford, Christian Walter, Arthur Heymans.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74138 )
Change subject: security/tpm: Handle S3 resume logging
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74138/comment/a28e2a71_225d05c6
PS1, Line 10: are reset, so the eventlog needs to be reset too.
Uhh... they really shouldn't be. […]
Yes... I mean, I'm not very familiar with measurement stuff (we don't use it for Chromebooks), but the piece you quoted sounds like you're not supposed to re-measure anything on resume. (That would also cause practical problems because your TCPA log isn't infinite, so if you kept measuring things again and again on every resume it would eventually overflow.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74138
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7049bf23fea876cdd19103af6e6fd3d5a20ed114
Gerrit-Change-Number: 74138
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 27 Apr 2023 01:11:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment