[M] Change in coreboot[main]: drivers/intel/fsp2_0: Add option to control debug log level using CBFS
Attention is currently required from: Andrey Petrov, Intel coreboot Reviewers, Jayvik Desai, Paul Menzel, Ronak Kanabar, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86001?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/intel/fsp2_0: Add option to control debug log level using CBFS ......................................................................
Patch Set 9:
(4 comments)
File src/drivers/intel/fsp2_0/debug.c:
https://review.coreboot.org/c/coreboot/+/86001/comment/8011920a_198a3678?usp... : PS6, Line 185: if (!CONFIG(USE_CBFS_FILE_OPTION_BACKEND))
Not really sure which comment you're referring to but it's possible I may have missed something. […]
Yes, thanks, I think that makes more sense.
File src/drivers/intel/fsp2_0/include/fsp/debug.h:
https://review.coreboot.org/c/coreboot/+/86001/comment/7fb2d4c9_ece96291?usp... : PS9, Line 71: * no serial log. Otherwise, use below log levels This text needs to be adjusted to reflect new code. Default loglevel is dependent on coreboot loglevel now, and the top should say something like "Retrieve ... from option backend (e.g. CBFS)" to clarify that other backends are also supported.
https://review.coreboot.org/c/coreboot/+/86001/comment/8cd606dd_f7ed420a?usp... : PS9, Line 81: * If disabled (!HAVE_CBFS_FILE_OPTION_BACKEND), the log levels will be determined by This should say `If OPTION_BACKEND_NONE` (and should maybe be combined with the text above saying what happens where the option is not present).
https://review.coreboot.org/c/coreboot/+/86001/comment/e4bae579_88b4161c?usp... : PS9, Line 87: * used for outputting MRC debug messages. Same stuff for this function.
-
Julius Werner (Code Review)