Attention is currently required from: Derek Huang, Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Kapil Porwal, Tarun.
Paul Menzel has posted comments on this change by Derek Huang. ( https://review.coreboot.org/c/coreboot/+/86673?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/intel/usb4: Add mainboard function to get EC port
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86673/comment/05665870_3453595b?usp... :
PS4, Line 9: This patch adds mainboard override function which allows for
: custom port mapping between CPU physical port and EC port to
: accommodate the non-sequential mapping. Mainboard code must
: implement this function if the CPU physical port to EC port
: mapping is not sequential.
Please re-flow for 72 characters per line. Then it also fits in four lines.
https://review.coreboot.org/c/coreboot/+/86673/comment/854ab95a_c85ef7ce?usp... :
PS4, Line 14:
Why is a weak function needed? Couldn’t that information be integrated into the devicetree?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86673?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibaad2a95d8624564ae012d23e8a7f19f6701db2c
Gerrit-Change-Number: 86673
Gerrit-PatchSet: 4
Gerrit-Owner: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jakub "Kuba" Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub "Kuba" Czapiga
czapiga@google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Mon, 03 Mar 2025 10:01:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No