Change in coreboot[master]: soc/amd/common/fsp/pci: Add helper methods for PCI IRQ table
Attention is currently required from: Jason Glenesk, Marshall Dawson, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52911 )
Change subject: soc/amd/common/fsp/pci: Add helper methods for PCI IRQ table ......................................................................
Patch Set 4:
(3 comments)
File src/soc/amd/common/fsp/pci/pci_routing_info.c:
https://review.coreboot.org/c/coreboot/+/52911/comment/cd3bfd2e_01e69d7d PS3, Line 44: sizeof(*routing_table)
sizeof(pci_routing_info) should also work and i'd find that a bit easier to read
Done
https://review.coreboot.org/c/coreboot/+/52911/comment/a137a08c_67ff8017 PS3, Line 76: >
this should probably be a >= and not a >, since ARRAY_SIZE(pcie_swizzle_table) is 4, but the maximum […]
Good catch!
https://review.coreboot.org/c/coreboot/+/52911/comment/ba26aaa3_6b4052f5 PS3, Line 79: >
probably same here
Done
-
Raul Rangel (Code Review)