the following patch was just integrated into master: commit e4807f30c50df8302f3ed34bad2febf073f85ab3 Author: Paul Menzel paulepanter@users.sourceforge.net Date: Fri Mar 29 12:51:31 2013 +0100
ASRock E350M1: PlatformGnbPcie.c: Do not return anything for void return type
When building the ASRock E350M1, the following warning is shown.
$ make # on Jenkins (build server) […] CC mainboard/asrock/e350m1/PlatformGnbPcie.romstage.o CC mainboard/asrock/e350m1/agesawrapper.romstage.o CC mainboard/asrock/e350m1/buildOpts.romstage.o src/mainboard/asrock/e350m1/PlatformGnbPcie.c: In function 'OemCustomizeInitEarly': src/mainboard/asrock/e350m1/PlatformGnbPcie.c:131:5: warning: 'return' with a value, in function returning void [enabled by default] […]
The function signature is (the return type might not be part of this though [1]),
VOID OemCustomizeInitEarly ( IN OUT AMD_EARLY_PARAMS *InitEarly )
so do not return anything.
All other AMD Family 14 boards already have the correct code. For example following commit fixed this for AMD Persimmon.
commit d7a696d0f229abccc95ff411f28d91b9b796ab74 Author: efdesign98 efdesign98@gmail.com Date: Thu Sep 15 15:24:26 2011 -0600
Persimmon updates for AMD F14 rev C0
Reviewed-on: http://review.coreboot.org/137
[1] http://cboard.cprogramming.com/cplusplus-programming/117286-what-exactly-fun...
Change-Id: Ie60246bd9bb8452efd096e6838d8610f6364a6aa Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-on: http://review.coreboot.org/2954 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth martin.roth@se-eng.com
Build-Tested: build bot (Jenkins) at Fri Mar 29 14:16:24 2013, giving +1 Reviewed-By: Martin Roth martin.roth@se-eng.com at Sat Mar 30 02:10:24 2013, giving +2 See http://review.coreboot.org/2954 for details.
-gerrit