Change in coreboot[master]: drivers/ocp/dmi: Add OCP_DMI driver for populating SMBIOS from IPMI F... - coreboot-gerrit

4 May 2020


      Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40308 )
Change subject: drivers/ocp/dmi: Add OCP_DMI driver for populating SMBIOS from IPMI FRU data
......................................................................
Patch Set 26:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40308/23/src/drivers/ocp/dmi/Kconfi... 
File src/drivers/ocp/dmi/Kconfig:
https://review.coreboot.org/c/coreboot/+/40308/23/src/drivers/ocp/dmi/Kconfi... 
PS23, Line 14: config BMC_KCS_BASE
...
I noticed this so I added define BMC_KCS_BASE to ocp_dmi. […]
For ramstage maybe I can add a global variable for it and sets it during ipmi_kcs_init() from dev->path.pnp.port, so all functions will use this global variable directly?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/40308
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c958dfad83216cd12545760a19d205efc2515b
Gerrit-Change-Number: 40308
Gerrit-PatchSet: 26
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Andrey Petrov andrey.petrov@gmail.com
Gerrit-CC: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 May 2020 09:53:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph patrick.rudolph@9elements.com
Comment-In-Reply-To: Johnny Lin
Gerrit-MessageType: comment