Paul Menzel (paulepanter@users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3953
-gerrit
commit 3c6c0af4faa847b768104b0d6fa0358c425e54a8 Author: Paul Menzel paulepanter@users.sourceforge.net Date: Wed Oct 2 21:59:38 2013 +0200
cpu/x86/mtrr/mtrr.c: Remove superfluous assignment to `type_index`
When building coreboot with the Clang static analyzer scan-build, it reports »Value stored to 'type_index' is never read«. Indeed, in `memranges_each_entry()` `type_index` is assigned a value before being read. So remove that line.
Change-Id: I6da2fb8be7157bb98c57281babd4a08ca0d9f7a7 Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net --- src/cpu/x86/mtrr/mtrr.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c index 8f1c35e..d168978 100644 --- a/src/cpu/x86/mtrr/mtrr.c +++ b/src/cpu/x86/mtrr/mtrr.c @@ -261,7 +261,6 @@ static void calc_fixed_mtrrs(void)
desc = &fixed_mtrr_desc[0]; last_desc = &fixed_mtrr_desc[ARRAY_SIZE(fixed_mtrr_desc) - 1]; - type_index = desc->range_index;
memranges_each_entry(r, phys_addr_space) { begin = range_entry_base_mtrr_addr(r);