Attention is currently required from: Felix Singer, Martin Roth, Mariusz Szafrański, Paul Menzel, Stefan Reinauer, Suresh Bellampalli, Vanessa Eusebio, Angel Pons, Michael Niewöhner, Michal Motyl, Kyösti Mälkki, Patrick Rudolph.
Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60830 )
Change subject: util/ifdtool: Add support for Denverton Soc
......................................................................
Patch Set 14:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/60830/comment/91cd11f7_c6095c9a
PS13, Line 718: has_gbe_region = (platform != PLATFORM_DNV);
: has_ec_region = (ifd_version >= IFD_VERSION_2) && (platform != PLATFORM_DNV);
: has_10gbe_0_region = (platform == PLATFORM_DNV);
: has_10gbe_1_region = (platform == PLATFORM_DNV);
will rework this into a function/macro for next time.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60830
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15939ce4672123f39a807d63c13ba7df98c57523
Gerrit-Change-Number: 60830
Gerrit-PatchSet: 14
Gerrit-Owner: Jeff Daly
jeffd@silicom-usa.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 03 Mar 2022 19:04:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jeff Daly
jeffd@silicom-usa.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment