Attention is currently required from: Meera Ravindranath, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56168 )
Change subject: drivers/intel/gma: Define structure for Opregion version ......................................................................
Patch Set 4:
(1 comment)
File src/drivers/intel/gma/opregion.c:
https://review.coreboot.org/c/coreboot/+/56168/comment/40b79b46_999b1835 PS3, Line 357: opregion->header.version = IGD_OPREGION_VERSION << 24;
Done that in the next CL here as I had to update the function of setting version - […]
Yes, we would need that function in this CL to ensure we don't break the current behavior with this CL. You can start with this in current CL :
``` /* Function to set the IGD Opregion version */ static void opregion_set_version(opregion_header_t *opheader) { opheader->over.major = 2; opheader->over.minor = 0; opheader->over.rsvd = 0; opheader->over.revision = 0; } ```
and update with the config checks in next CL.