Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46470 )
Change subject: soc/intel/common/acpi: rename LPID to PEPD ......................................................................
soc/intel/common/acpi: rename LPID to PEPD
Rename LPID to PEPD for consistency. PEPD means "Power Engine Plug-In Device" and is the name Intel and vendors usually use, so let's comply.
Change-Id: I1caa009a3946b1c55da8afbae058cafe98940c6d Signed-off-by: Michael Niewöhner foss@mniewoehner.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/46470 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl M src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl M src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl M src/mainboard/google/volteer/mainboard.asl M src/soc/intel/common/block/acpi/acpi/pep.asl 5 files changed, 20 insertions(+), 20 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl b/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl index 5ba7be7..6219f27 100644 --- a/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/drallion/variants/drallion/include/variant/acpi/mainboard.asl @@ -4,7 +4,7 @@ #define TS_PD GPP_E7 #define HDMI_PD GPP_E16
-/* Method called from LPIT prior to enter s0ix state */ +/* Method called from PEPD prior to enter s0ix state */ Method (MS0X, 1) { If (Arg0) { diff --git a/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl b/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl index 6bc145a..96783ca 100644 --- a/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/sarien/variants/arcada/include/variant/acpi/mainboard.asl @@ -3,7 +3,7 @@ #define CAM_EN GPP_B11 /* Active low */ #define TS_PD GPP_E7
-/* Method called from LPIT prior to enter s0ix state */ +/* Method called from PEPD prior to enter s0ix state */ Method (MS0X, 1) { If (Arg0) { diff --git a/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl b/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl index 6bc145a..96783ca 100644 --- a/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl @@ -3,7 +3,7 @@ #define CAM_EN GPP_B11 /* Active low */ #define TS_PD GPP_E7
-/* Method called from LPIT prior to enter s0ix state */ +/* Method called from PEPD prior to enter s0ix state */ Method (MS0X, 1) { If (Arg0) { diff --git a/src/mainboard/google/volteer/mainboard.asl b/src/mainboard/google/volteer/mainboard.asl index e2f6d11..0e9bb8c 100644 --- a/src/mainboard/google/volteer/mainboard.asl +++ b/src/mainboard/google/volteer/mainboard.asl @@ -30,7 +30,7 @@
/* * S0ix Entry/Exit Notifications - * Called from _SB.LPID._DSM + * Called from _SB.PEPD._DSM */ Method (MS0X, 1, Serialized) { diff --git a/src/soc/intel/common/block/acpi/acpi/pep.asl b/src/soc/intel/common/block/acpi/acpi/pep.asl index 0d9f1c9..1bbecef 100644 --- a/src/soc/intel/common/block/acpi/acpi/pep.asl +++ b/src/soc/intel/common/block/acpi/acpi/pep.asl @@ -1,20 +1,20 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#define LPID_DSM_ARG2_ENUM_FUNCTIONS 0 -#define LPID_DSM_ARG2_GET_DEVICE_CONSTRAINTS 1 +#define PEPD_DSM_ARG2_ENUM_FUNCTIONS 0 +#define PEPD_DSM_ARG2_GET_DEVICE_CONSTRAINTS 1
-#define LPID_DSM_ARG2_GET_CRASH_DUMP_DEV 2 -#define LPID_DSM_ARG2_DISPLAY_OFF_NOTIFY 3 -#define LPID_DSM_ARG2_DISPLAY_ON_NOTIFY 4 -#define LPID_DSM_ARG2_S0IX_ENTRY 5 -#define LPID_DSM_ARG2_S0IX_EXIT 6 +#define PEPD_DSM_ARG2_GET_CRASH_DUMP_DEV 2 +#define PEPD_DSM_ARG2_DISPLAY_OFF_NOTIFY 3 +#define PEPD_DSM_ARG2_DISPLAY_ON_NOTIFY 4 +#define PEPD_DSM_ARG2_S0IX_ENTRY 5 +#define PEPD_DSM_ARG2_S0IX_EXIT 6
External(_SB.MS0X, MethodObj) External(_SB.PCI0.LPCB.EC0.S0IX, MethodObj) External(_SB.PCI0.EGPM, MethodObj) External(_SB.PCI0.RGPM, MethodObj)
-Device(LPID) +Device(PEPD) { Name(_ADR, 0x00000000) Name(_CID, EISAID("PNP0D80")) @@ -25,35 +25,35 @@ /* * Enum functions */ - If(Arg2 == LPID_DSM_ARG2_ENUM_FUNCTIONS) { + If(Arg2 == PEPD_DSM_ARG2_ENUM_FUNCTIONS) { Return(Buffer(One) {0x60}) } /* * Function 1 - Get Device Constraints */ - If(Arg2 == LPID_DSM_ARG2_GET_DEVICE_CONSTRAINTS) { + If(Arg2 == PEPD_DSM_ARG2_GET_DEVICE_CONSTRAINTS) { Return(Package(5) {0, Ones, Ones, Ones, Ones}) } /* * Function 2 - Get Crash Dump Device */ - If(Arg2 == LPID_DSM_ARG2_GET_CRASH_DUMP_DEV) { + If(Arg2 == PEPD_DSM_ARG2_GET_CRASH_DUMP_DEV) { Return(Buffer(One) {0x0}) } /* * Function 3 - Display Off Notification */ - If(Arg2 == LPID_DSM_ARG2_DISPLAY_OFF_NOTIFY) { + If(Arg2 == PEPD_DSM_ARG2_DISPLAY_OFF_NOTIFY) { } /* * Function 4 - Display On Notification */ - If(Arg2 == LPID_DSM_ARG2_DISPLAY_ON_NOTIFY) { + If(Arg2 == PEPD_DSM_ARG2_DISPLAY_ON_NOTIFY) { } /* * Function 5 - Low Power S0 Entry Notification */ - If(Arg2 == LPID_DSM_ARG2_S0IX_ENTRY) { + If(Arg2 == PEPD_DSM_ARG2_S0IX_ENTRY) { /* Inform the EC */ If (CondRefOf (_SB.PCI0.LPCB.EC0.S0IX)) { _SB.PCI0.LPCB.EC0.S0IX(1) @@ -76,7 +76,7 @@ /* * Function 6 - Low Power S0 Exit Notification */ - If(Arg2 == LPID_DSM_ARG2_S0IX_EXIT) { + If(Arg2 == PEPD_DSM_ARG2_S0IX_EXIT) { /* Inform the EC */ If (CondRefOf (_SB.PCI0.LPCB.EC0.S0IX)) { _SB.PCI0.LPCB.EC0.S0IX(0) @@ -97,4 +97,4 @@
Return(Buffer(One) {0x00}) } // Method(_DSM) -} // Device (LPID) +} // Device (PEPD)
-
Nico Huber (Code Review)