Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/61043 )
Change subject: soc/mediatek: Include 'console/console.h' when appropriate ......................................................................
soc/mediatek: Include 'console/console.h' when appropriate
Found using: diff <(git grep -l '#include <console/console.h>' -- src/) <(git grep -l 'console_time_report|console_time_get_and_reset|do_putchar|vprintk|printk|console_log_level|console_init|get_log_level|CONSOLE_ENABLE|get_console_loglevel|die_notify|die_with_post_code|die|arch_post_code|mainboard_post|post_code|RAM_SPEW|RAM_DEBUG|BIOS_EMERG|BIOS_ALERT|BIOS_CRIT|BIOS_ERR|BIOS_WARNING|BIOS_NOTICE|BIOS_INFO|BIOS_DEBUG|BIOS_SPEW|BIOS_NEVER' -- src/)
Change-Id: I93f930de5a2a477ec4c0d8e5c8c57b25f5e4252c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/61043 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Hung-Te Lin hungte@chromium.org Reviewed-by: Xixi Chen xixi.chen@mediatek.corp-partner.google.com --- M src/soc/mediatek/common/include/soc/msdc.h M src/soc/mediatek/common/msdc.c M src/soc/mediatek/mt8173/include/soc/dramc_pi_api.h M src/soc/mediatek/mt8183/i2c.c M src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h M src/soc/mediatek/mt8192/i2c.c 6 files changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Xixi Chen: Looks good to me, but someone else must approve
diff --git a/src/soc/mediatek/common/include/soc/msdc.h b/src/soc/mediatek/common/include/soc/msdc.h index 798b0f6..0f8ba7a 100644 --- a/src/soc/mediatek/common/include/soc/msdc.h +++ b/src/soc/mediatek/common/include/soc/msdc.h @@ -4,6 +4,7 @@ #define SOC_MEDIATEK_COMMON_MSDC_H
#include <commonlib/sd_mmc_ctrlr.h> +#include <console/console.h>
/*------------------------------*/ /* Register Offset */ diff --git a/src/soc/mediatek/common/msdc.c b/src/soc/mediatek/common/msdc.c index a5a8a6b..8208886 100644 --- a/src/soc/mediatek/common/msdc.c +++ b/src/soc/mediatek/common/msdc.c @@ -6,6 +6,7 @@ #include <cbmem.h> #include <commonlib/bsd/helpers.h> #include <commonlib/storage/sd_mmc.h> +#include <console/console.h> #include <delay.h> #include <device/mmio.h> #include <lib.h> diff --git a/src/soc/mediatek/mt8173/include/soc/dramc_pi_api.h b/src/soc/mediatek/mt8173/include/soc/dramc_pi_api.h index 8ead392..8eb58d0 100644 --- a/src/soc/mediatek/mt8173/include/soc/dramc_pi_api.h +++ b/src/soc/mediatek/mt8173/include/soc/dramc_pi_api.h @@ -6,7 +6,6 @@ #include <soc/dramc_common.h> #include <soc/dramc_soc.h> #include <soc/emi.h> -#include <console/console.h>
enum { MAX_CLKO_DELAY = 15 diff --git a/src/soc/mediatek/mt8183/i2c.c b/src/soc/mediatek/mt8183/i2c.c index 193f4b9..1aaa236 100644 --- a/src/soc/mediatek/mt8183/i2c.c +++ b/src/soc/mediatek/mt8183/i2c.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <assert.h> +#include <console/console.h> #include <device/mmio.h> #include <soc/i2c.h> #include <soc/gpio.h> diff --git a/src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h b/src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h index 5ee6300..707c867 100644 --- a/src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h +++ b/src/soc/mediatek/mt8183/include/soc/dramc_pi_api.h @@ -6,7 +6,6 @@ #include <types.h> #include <soc/dramc_common.h> #include <soc/emi.h> -#include <console/console.h>
#define DATLAT_TAP_NUMBER 32 #define HW_REG_SHUFFLE_MAX 4 diff --git a/src/soc/mediatek/mt8192/i2c.c b/src/soc/mediatek/mt8192/i2c.c index 5f1e3a0..6d88833 100644 --- a/src/soc/mediatek/mt8192/i2c.c +++ b/src/soc/mediatek/mt8192/i2c.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <assert.h> +#include <console/console.h> #include <device/mmio.h> #include <soc/i2c.h> #include <soc/gpio.h>