Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36288 )
Change subject: cpu/amd/mtrr: Add uma resource based on cbmem_top
......................................................................
Patch Set 31:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36288/31/src/cpu/amd/mtrr/amd_mtrr....
File src/cpu/amd/mtrr/amd_mtrr.c:
https://review.coreboot.org/c/coreboot/+/36288/31/src/cpu/amd/mtrr/amd_mtrr....
PS31, Line 83: uint32_t top_of_cacheable = (uint32_t)cbmem_top();
The assumption doesn't hold for soc/amd/, AFAICS. Not sure what to do
about it. Maybe add a
if (!CONFIG(CBMEM_TOP_BACKUP))
dead_code();
?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36288
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7bfc511be1d325f30d7ba073eb06ecc0aca4d544
Gerrit-Change-Number: 36288
Gerrit-PatchSet: 31
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 10 Nov 2019 22:56:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment