Attention is currently required from: Ian Feng, Dtrain Hsu, Henry Sun, Paul Menzel, Shou-Chieh Hsu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56248 )
Change subject: mb/google/dedede/var/cret: Enable/disable Touchscreen based on FW_CONFIG
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/56248/comment/67b4a120_8723f087
PS4, Line 13: field TOUCHSCREEN 5
: option TOUCHSCREEN_ABSENT 0
: option TOUCHSCREEN_PRESENT 1
: end
Does this FW config field apply to the entire Dedede design or does it apply only to Cret?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56248
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice517c034e2dab93bb27e75dccf06d9a0936526b
Gerrit-Change-Number: 56248
Gerrit-PatchSet: 4
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Comment-Date: Thu, 15 Jul 2021 17:04:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment