Attention is currently required from: Felix Singer, Name of user not set #1003506, Martin Roth, Angel Pons, Michael Niewöhner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52594 )
Change subject: mainboard: Add Synology DS918+ ......................................................................
Patch Set 7:
(62 comments)
File src/mainboard/synology/ds918plus/early_gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/6134c66d_d472b09e PS7, Line 40: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_210, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ1_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/7b788d59_92848f66 PS7, Line 58: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_38, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/e23c7a52_74c6f0f9 PS7, Line 59: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_39, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/2ae08a7b_4a3b09d0 PS7, Line 60: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_42, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART1_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/e3509d39_55c7c27e PS7, Line 61: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_43, UP_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_TXD */ line over 96 characters
File src/mainboard/synology/ds918plus/gpio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/ad11ad7f_4063cacd PS7, Line 47: PAD_CFG_GPI_APIC_IOS(GPIO_33, DN_20K, DEEP, EDGE_SINGLE, NONE, IGNORE, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/fcaeea48_f2981615 PS7, Line 52: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_38, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/1f719b6c_abe27d53 PS7, Line 53: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_39, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/f6601caf_98a1e1d8 PS7, Line 54: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_40, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART0_RTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/6ea45fc3_759c1b03 PS7, Line 55: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_41, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_CTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/2cf4b306_5b1ab2d0 PS7, Line 56: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_42, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART1_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/a41d0908_a6d02707 PS7, Line 57: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_43, UP_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/cd3617da_0318b69e PS7, Line 58: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_44, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART1_RTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/cd0365de_856cb5d1 PS7, Line 59: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_45, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* LPSS_UART1_CTS_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/c6f42220_dcb268e3 PS7, Line 85: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(CNV_BRI_DT, DN_20K, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/1ea675db_ff2f2d89 PS7, Line 86: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(CNV_BRI_RSP, DN_20K, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/46da975f_7e7928e3 PS7, Line 102: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_193, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/1e2db510_3318e173 PS7, Line 103: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_194, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/023580b8_6edbd1d0 PS7, Line 104: PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_195, 1, DEEP, DN_20K, Tx0RxDCRx0, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/37ea0791_7e356246 PS7, Line 114: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_FS0, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/78c9fd2f_d7d68d0f PS7, Line 115: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_FS1, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/23902f9e_a1718963 PS7, Line 117: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_RXD, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/66ad6c40_5836754b PS7, Line 118: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_TXD, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/eeb6500a_bb82d777 PS7, Line 119: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMC_SPI_CLK, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/f0816bec_ea71aed7 PS7, Line 121: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMIC_RESET_B, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/e3942ba7_15a27918 PS7, Line 126: PAD_CFG_GPI_TRIG_IOSSTATE_OWN(PMIC_STDBY, NONE, DEEP, OFF, IGNORE, ACPI), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/178b0996_e0cbc4e8 PS7, Line 137: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_81, DN_20K, DEEP, NF2, TxDRxE, ENPD), /* AVS_I2C4_SDI */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/f0b42c5f_2496faa8 PS7, Line 139: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_83, DN_20K, DEEP, NF1, TxDRxE, ENPD), /* AVS_DMIC_DATA_2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/12fcecf1_ba24c3c3 PS7, Line 147: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_91, DN_20K, DEEP, NF1, TxDRxE, ENPD), /* AVS_I2S3_SDI */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/cd9fa803_07cfe648 PS7, Line 157: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_104, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_CLK */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/480e657e_039d41c8 PS7, Line 158: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_105, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_FS0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/11170cd6_a6778070 PS7, Line 159: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_106, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_FS1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/a18f0aea_df6a40a7 PS7, Line 160: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_109, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_RXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/316f669f_25ff80f9 PS7, Line 161: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_110, UP_20K, DEEP, NF1, HIZCRx0, ENPD), /* SIO_SPI_0_TXD */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/c7a3fe76_da519f97 PS7, Line 177: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_124, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C0_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/e251d0fd_778a2773 PS7, Line 178: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_125, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C0_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/34e1c4ec_289a2d50 PS7, Line 179: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_126, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C1_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/30a756c0_fa475908 PS7, Line 180: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_127, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C1_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/d1c3761e_42967b63 PS7, Line 181: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_128, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C2_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/f33a4e96_8a176745 PS7, Line 182: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_129, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C2_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/c7a64e28_3f5160ca PS7, Line 183: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_130, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C3_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/26822350_1d439d36 PS7, Line 184: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_131, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C3_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/a0f05faa_3816d55b PS7, Line 185: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_132, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C4_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/44c99523_c040523f PS7, Line 186: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_133, UP_1K, DEEP, NF1, Tx1RxDCRx1, ENPU), /* LPSS_I2C4_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/d594c632_04781c32 PS7, Line 187: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_134, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C0_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/76cceb46_67cba4fa PS7, Line 188: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_135, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C0_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/612450a3_82161408 PS7, Line 189: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_136, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C1_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/1d635073_48fa4921 PS7, Line 190: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_137, NONE, DEEP, NF2, IGNORE, ENPU), /* ISH_I2C1_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/93d1ba98_ee3edb75 PS7, Line 191: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_138, UP_1K, DEEP, NF1, Tx0RxDCRx0, ENPU), /* LPSS_I2C7_SDA */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/33862de1_17009cb9 PS7, Line 192: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_139, UP_1K, DEEP, NF1, Tx0RxDCRx0, ENPU), /* LPSS_I2C7_SCL */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/93482f5b_97bf91ef PS7, Line 203: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ0_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/c470eead_5239c183 PS7, Line 204: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_210, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ1_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/d5af1070_4567d445 PS7, Line 205: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_211, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ2_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/df30d571_0ef92207 PS7, Line 206: PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_212, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* PCIE_CLKREQ3_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/199a0861_a98eb9fa PS7, Line 216: PAD_CFG_NF_IOSTANDBY_IGNORE(PMU_RESETBUTTON_B, NONE, DEEP, NF1), /* PMU_RSTBTN_N */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/ae646f70_b030fbd7 PS7, Line 221: PAD_CFG_GPO_IOSSTATE_IOSTERM(PMU_WAKE_B, 1, DEEP, UP_20K, IGNORE, SAME), /* GPIO */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/72c924e7_1f574624 PS7, Line 264: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_CLKOUT1, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_CLKOUT1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/ee344b1c_aa8408d5 PS7, Line 265: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD0, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD0 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/a41364f4_44d61a3f PS7, Line 266: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD1, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD1 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/f6f3342f_8f183990 PS7, Line 267: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD2, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD2 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/a4b1db6e_3b9f6f40 PS7, Line 268: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_AD3, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_AD3 */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118479): https://review.coreboot.org/c/coreboot/+/52594/comment/9c6cea8f_786da9d9 PS7, Line 270: PAD_CFG_NF_IOSSTATE_IOSTERM(LPC_FRAMEB, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPC_FRAMEB */ line over 96 characters