Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39564 )
Change subject: util/inteltool: spi: make Sunrise Point dumping work
......................................................................
Patch Set 5: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39564/5/util/inteltool/spi.c
File util/inteltool/spi.c:
https://review.coreboot.org/c/coreboot/+/39564/5/util/inteltool/spi.c@94
PS5, Line 94: { 0xd4, 4, "BIOS_SBRS - SPI Bus Requester Status" },
Do we have to prefix everything with BIOS_? I know the datasheets do...
https://review.coreboot.org/c/coreboot/+/39564/5/util/inteltool/spi.c@406
PS5, Line 406: ;
one ; should be enough :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39564
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7d4dae07d493414d6c7a0c4593ff28dd5b60faa
Gerrit-Change-Number: 39564
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 21 Mar 2020 13:02:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment