Attention is currently required from: Hung-Te Lin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59245 )
Change subject: soc/mediatek/mt8186: Add support for PMIC MT6366 ......................................................................
Patch Set 1:
(7 comments)
File src/soc/mediatek/mt8186/mt6366.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/84aeba0d_3c6fa010 PS1, Line 174: };; Statements terminations use 1 semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/728a3665_5b1dce6f PS1, Line 606: printk(BIOS_WARNING, "%s: ID = %#x \n", __func__, unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/7b0225c6_d56be240 PS1, Line 647: BUG(); Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/1b5c5df8_68f06713 PS1, Line 707: while (!stopwatch_expired(&voltage_settled)) suspect code indent for conditional statements (8, 49)
File src/soc/mediatek/mt8186/pmic_wrap.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/b03713cf_fe3d0d1f PS1, Line 63: write32(&mt8186_infracfg_ao->module_sw_cg_0_set, 0x0000000f); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/45b5958f_24d7c1c7 PS1, Line 63: write32(&mt8186_infracfg_ao->module_sw_cg_0_set, 0x0000000f); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133099): https://review.coreboot.org/c/coreboot/+/59245/comment/d953790c_9b2b17d9 PS1, Line 63: write32(&mt8186_infracfg_ao->module_sw_cg_0_set, 0x0000000f); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)