Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36441 )
Change subject: submodules: Add 3rdparty/amd_blobs ......................................................................
submodules: Add 3rdparty/amd_blobs
This is currently an empty repo. The intention for amd_blobs may be found in Documentation/soc/amd/amdblobs_license.md. A subsequent patch will make the repo's init and checkout optional based on a Kconfig symbol.
Change-Id: Ia93fb2711beaea4cb1c8e5d71dc3a9e0facc5485 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M .gitmodules A 3rdparty/amd_blobs 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/36441/1
diff --git a/.gitmodules b/.gitmodules index deb3cf0..d90d29b 100644 --- a/.gitmodules +++ b/.gitmodules @@ -37,3 +37,8 @@ [submodule "3rdparty/ffs"] path = 3rdparty/ffs url = ../ffs.git +[submodule "3rdparty/amd_blobs"] + path = 3rdparty/amd_blobs + url = https://review.coreboot.org/amd_blobs + update = none + ignore = dirty diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs new file mode 160000 index 0000000..cf22731 --- /dev/null +++ b/3rdparty/amd_blobs @@ -0,0 +1 @@ +Subproject commit cf227316b0fbd3995854ce21e81a63270b29bfb5
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36441 )
Change subject: submodules: Add 3rdparty/amd_blobs ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36441 )
Change subject: submodules: Add 3rdparty/amd_blobs ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36441/1/.gitmodules File .gitmodules:
https://review.coreboot.org/c/coreboot/+/36441/1/.gitmodules@42 PS1, Line 42: https://review.coreboot.org Isn't this supposed to be a relative path?
Hello build bot (Jenkins), Nico Huber, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36441
to look at the new patch set (#2).
Change subject: submodules: Add 3rdparty/amd_blobs ......................................................................
submodules: Add 3rdparty/amd_blobs
This is currently an empty repo. The intention for amd_blobs may be found in Documentation/soc/amd/amdblobs_license.md. A subsequent patch will make the repo's init and checkout optional based on a Kconfig symbol.
Change-Id: Ia93fb2711beaea4cb1c8e5d71dc3a9e0facc5485 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M .gitmodules A 3rdparty/amd_blobs 2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/36441/2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36441 )
Change subject: submodules: Add 3rdparty/amd_blobs ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36441/1/.gitmodules File .gitmodules:
https://review.coreboot.org/c/coreboot/+/36441/1/.gitmodules@42 PS1, Line 42: https://review.coreboot.org
Isn't this supposed to be a relative path?
Yep I'd say so. I added it via the command line and missed that when I added update and ignore.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36441 )
Change subject: submodules: Add 3rdparty/amd_blobs ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36441 )
Change subject: submodules: Add 3rdparty/amd_blobs ......................................................................
submodules: Add 3rdparty/amd_blobs
This is currently an empty repo. The intention for amd_blobs may be found in Documentation/soc/amd/amdblobs_license.md. A subsequent patch will make the repo's init and checkout optional based on a Kconfig symbol.
Change-Id: Ia93fb2711beaea4cb1c8e5d71dc3a9e0facc5485 Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/36441 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M .gitmodules A 3rdparty/amd_blobs 2 files changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/.gitmodules b/.gitmodules index deb3cf0..010ab6b 100644 --- a/.gitmodules +++ b/.gitmodules @@ -37,3 +37,8 @@ [submodule "3rdparty/ffs"] path = 3rdparty/ffs url = ../ffs.git +[submodule "3rdparty/amd_blobs"] + path = 3rdparty/amd_blobs + url = ../amd_blobs + update = none + ignore = dirty diff --git a/3rdparty/amd_blobs b/3rdparty/amd_blobs new file mode 160000 index 0000000..cf22731 --- /dev/null +++ b/3rdparty/amd_blobs @@ -0,0 +1 @@ +Subproject commit cf227316b0fbd3995854ce21e81a63270b29bfb5
-
Marshall Dawson (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)