Attention is currently required from: Chen-Tsung Hsieh, jitao shi, Jitao Shi, Yu-Ping Wu.
Shaoming Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51432 )
Change subject: soc/mediatek: dsi: fine tune the delta time for EoTp
......................................................................
Patch Set 5:
(2 comments)
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/51432/comment/6bf57fa0_15cc7fe0
PS2, Line 207: 10
Your implementation in patchset_5 is not align with b/173603645#comment63. […]
The effect is the same with MIPI_DSI_MODE_EOT_PACKET, 12 byte also.
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/51432/comment/5cb276f2_0ed6b06e
PS5, Line 213: 6
Do we need to modify it?
It's same with before, delta += 6
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51432
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0666068cfb04b78eb706278814163f050da32b9c
Gerrit-Change-Number: 51432
Gerrit-PatchSet: 5
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-CC: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-CC: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-CC: Shaoming Chen
shaoming.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-Attention: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-Attention: jitao shi
jitao.shi@mediatek.com
Gerrit-Attention: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 01 Apr 2021 05:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Chen-Tsung Hsieh
chentsung@google.com
Comment-In-Reply-To: Chen-Tsung Hsieh
chentsung@chromium.org
Comment-In-Reply-To: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment