Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF ......................................................................
Patch Set 74:
Patch Set 74:
(2 comments)
Patch Set 74:
Patch Set 74:
I had a look on Supermicro's products list, especially on the X11 series, when I bought my X11SSM-F some days ago (I am currently working on porting coreboot to that board, too). I just realized that X11SSM-F and X11SSH-TF are basically the same board with just some minor differences (SSH has an m.2 slot and 10GBase-T).
I am wondering if it may be sensible to group those boards in a different scheme than suggested here (mainboards/x11ssh/tf), because we can support more boards this way more simple.
Many X11SS* boards share the same chipset and are more or less the same boards but have only minimal differences in internal/external interfaces.
My suggestion would be to group all these mainboards by chipset and make the rest configurable by selecting the specific board in Kconfig.
This could result in the following tree:
src/mainboard/supermicro/ src/mainboard/supermicro/c236/variants/x11ssh-f/ src/mainboard/supermicro/c236/variants/x11ssh-tf/ src/mainboard/supermicro/c236/variants/x11ssm-f/ src/mainboard/supermicro/c232/variants/... ...
As one chipset does only appear in one series but a series has multiple chipsets, this could also look like this one:
src/mainboard/supermicro/ src/mainboard/supermicro/x10/c222/variants/... src/mainboard/supermicro/x10/c224/variants/... src/mainboard/supermicro/x11/c236/variants/ssh-f/ src/mainboard/supermicro/x11/c236/variants/ssh-tf/ src/mainboard/supermicro/x11/c236/variants/ssm-f/ src/mainboard/supermicro/x11/c232/variants/... ...
These boards have C236 and I would not be surprised if those boards work with mostly identical coreboot code/config: X11SSH X11SSH-F X11SSH-TF X11SSH-CTF X11SSi-LN4F X11SSM X11SSM-F X11SSM-TF X11SSM-CTF X11SSZ-F X11SSZ-TLN4F X11SSW-F X11SSW-TF X11SSW-4TF X11SSH-GTF-1585L (soldered CPU, but no SoC) X11SSH-GTF-1585 (soldered CPU, but no SoC) X11SSH-GF-1585L (soldered CPU, but no SoC) X11SSH-GF-1585 (soldered CPU, but no SoC) X11SSA-F X11SSD-F X11SSE-F
Is this structure used somewhere else as well in the coreboot tree? I dont think we should reinvent something new and mix up chipsets with vendors and board variants.
No, currently not but we will be reimplementing stuff over and over again for these boards otherwise
Well, another idea, ignoring the fact that there are x11ss boards that would not fit in there. This also would become very confusing...
src/mainboard/supermicro/ src/mainboard/supermicro/x11ss/variants/x11ssh-f/ src/mainboard/supermicro/x11ss/variants/x11ssh-tf/ src/mainboard/supermicro/x11ss/variants/x11ssm-f/ src/mainboard/supermicro/x11ss/variants/...
-
Michael Niewöhner (Code Review)