Attention is currently required from: Daniel Peng, Eric Lai, Karthik Ramasubramanian, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78310?usp=email )
Change subject: mb/google/brya/var/marasov: Enable wifi sar table for Intel module
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
File src/mainboard/google/brya/variants/marasov/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/78310/comment/21c1dbaa_3a47b744 :
PS2, Line 20: option WIFI_SAR_ID_0 0
In our project, "WIFI_SAR_ID_0" is for MTK wifi module and "WIFI_SAR_ID_1" is for Intel wifi module. […]
Acknowledged
File src/mainboard/google/brya/variants/marasov/variant.c:
https://review.coreboot.org/c/coreboot/+/78310/comment/2233d6db_7efe4ca8 :
PS2, Line 13: printk(BIOS_INFO, "Use wifi_sar_1.hex.\n");
This is just to print information to know when we used for Intel wifi module AX211NGW.
If you have concern that we don't need this msg, I can remove it.
lets keep it in that way
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78310?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5b5c6bea6c2c916fb682044218ec7b3a5d2659f6
Gerrit-Change-Number: 78310
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kyle Lin
kylelinck@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 02 Nov 2023 07:42:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-MessageType: comment