Attention is currently required from: Sean Rhodes.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72800 )
Change subject: soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT
......................................................................
Patch Set 8:
(1 comment)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/72800/comment/35655312_527e77fb
PS4, Line 1004: Don't support D3Cold"
: default n if NO_S0IX_SUPPORT
hi Michael, thanks for finding the bug/ error here. […]
Sheng, while I usually would agree fixing stuff instead of reverting, there are IMHO two strong arguments against, in that case:
1) Since there are more flaws in this series of changes, it's hard to believe for me that there was any proper review. Your statement regarding lack of review resources emphasizes this.
2) Due to the conflicts created, I fear these changes create some sort of chaos in the tree as soon as the options get used by other boards, making later cleanup a cumbersome process, as one has to be careful to not break any of these boards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I718952165daa6471f11e8025e745fe7c249d3b46
Gerrit-Change-Number: 72800
Gerrit-PatchSet: 8
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Comment-Date: Fri, 07 Apr 2023 19:05:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lean Sheng Tan
sheng.tan@9elements.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment