Change in coreboot[master]: Makefile.inc: Generate master header and pointer as C structs

[Arthur Heymans (Code Review)]

Attention is currently required from: Martin Roth, Julius Werner, Arthur Heymans, Yu-Ping Wu.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59132 )

Change subject: Makefile.inc: Generate master header and pointer as C structs
......................................................................


Patch Set 6:

(6 comments)

File src/arch/x86/header_pointer.c:

https://review.coreboot.org/c/coreboot/+/59132/comment/72f2fab5_905315c2 
PS6, Line 7: __attribute__((used, __section__(".header_pointer"))) const uint32_t header_pointer =
> > Wouldn't it be simpler to just merge this with the src/lib version and wrap the section attribute  […]
> > Done

File src/lib/cbfs_master_header.c:

https://review.coreboot.org/c/coreboot/+/59132/comment/52463f9e_46f4309c 
PS6, Line 10: FMAP_SECTION_FLASH_SIZE
> I believe this needs to be […]
> Done

https://review.coreboot.org/c/coreboot/+/59132/comment/61b0beab_9294b54c 
PS6, Line 11: 	.bootblocksize = cpu_to_be32(4),
> This should probably have a comment about why this is 4... […]
> Done

https://review.coreboot.org/c/coreboot/+/59132/comment/0d128e69_09ddfbbc 
PS6, Line 12: 	.align = cpu_to_be32(64),
> You should be able to use the CBFS_ALIGNMENT constant here.
> Done

https://review.coreboot.org/c/coreboot/+/59132/comment/55c16aac_b7c5caec 
PS6, Line 13: FMAP_SECTION_FLASH_START
> > Isn't this just 0? Rather than assuming that all FMAPs are named "FLASH", I think it's easier to j […]
> > Done

File src/lib/master_header_pointer.c:

https://review.coreboot.org/c/coreboot/+/59132/comment/86b9c4be_234eeeb9 
PS6, Line 7: __attribute((used))
> > I don't think you need this? We've never needed it for other structs... […]
> > Done