Attention is currently required from: Martin Roth, Julius Werner, Arthur Heymans, Yu-Ping Wu.
6 comments:
File src/arch/x86/header_pointer.c:
Patch Set #6, Line 7: __attribute__((used, __section__(".header_pointer"))) const uint32_t header_pointer =
> Wouldn't it be simpler to just merge this with the src/lib version and wrap the section attribute […]
Done
File src/lib/cbfs_master_header.c:
Patch Set #6, Line 10: FMAP_SECTION_FLASH_SIZE
I believe this needs to be […]
Done
Patch Set #6, Line 11: .bootblocksize = cpu_to_be32(4),
This should probably have a comment about why this is 4... […]
Done
Patch Set #6, Line 12: .align = cpu_to_be32(64),
You should be able to use the CBFS_ALIGNMENT constant here.
Done
Patch Set #6, Line 13: FMAP_SECTION_FLASH_START
> Isn't this just 0? Rather than assuming that all FMAPs are named "FLASH", I think it's easier to j […]
Done
File src/lib/master_header_pointer.c:
Patch Set #6, Line 7: __attribute((used))
> I don't think you need this? We've never needed it for other structs... […]
Done
To view, visit change 59132. To unsubscribe, or for help writing mail filters, visit settings.