Attention is currently required from: Bora Guvendik, Kapil Porwal, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75555?usp=email )
Change subject: mb/google/rex: Update GPIO PAD IO Standby State
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/75555/comment/65e92ed7_d42f5738 :
PS3, Line 19: PAD_CFG_NF_IOSSTATE(GPP_A00, UP_20K, DEEP, NF1, IGNORE),
let me understand the problem, was the issue due to #1 or #2 below or for both ?
1. CB was not configuring these PADs as Native Function
2. Not skipping the GPIO IO standby programming
wondering why can't we configure as below or even adding LOCK
PAD_CFG_NF(GPP_A00, UP_20K, DEEP, NF1),
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75555?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If96c1e71fdde784a55fe079875915ffa5a4f548a
Gerrit-Change-Number: 75555
Gerrit-PatchSet: 3
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Thu, 01 Jun 2023 09:58:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment