Change in coreboot[master]: soc/intel/ehl: Provide function to change PHY-to-MAC IRQ polarity
Attention is currently required from: Paul Menzel, Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63888 )
Change subject: soc/intel/ehl: Provide function to change PHY-to-MAC IRQ polarity ......................................................................
Patch Set 4:
(3 comments)
File src/soc/intel/elkhartlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/63888/comment/9813120d_e697b21d PS2, Line 246: config EHL_TSN_PHY2MAC_IRQ_ACTIVE_HIGH
Instead of Kconfig could that be made a devicetree option?
I will have a look at this...
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/63888/comment/4493e111_f7f844a7 PS2, Line 38: udelay(TSN_GMII_DELAY_US);
Do you need this udelay() here at all? Are there restrictions in how often you can read the busy bit […]
I tested it and it seems to work the same way.
https://review.coreboot.org/c/coreboot/+/63888/comment/b350eda8_b23e6a5d PS2, Line 44: Timeout at %ld
Maybe: […]
Done
-
Mario Scheithauer (Code Review)