Attention is currently required from: Raul Rangel, Rob Barnes. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62599 )
Change subject: mb/google/guybrush: Enable EC SMI handler ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62599/comment/be5ec6d3_2d3b46d4 PS1, Line 10: are disabled once ACPI is : enabled Just for my knowledge, what component writes to ACPI SMI command port and triggers this ACPI Enable SMI?
File src/mainboard/google/guybrush/smihandler.c:
https://review.coreboot.org/c/coreboot/+/62599/comment/6506a3f3_3725a270 PS1, Line 48: chromeec_smi_process_events(); Does this end up handling the LID_CLOSED event as an SMI event when OS is expected to handle it.