Attention is currently required from: V Sowmya, Shahina Shaik, Haribalaraman Ramasubramanian, Sridhar Siricilla, Balaji Manigandan.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69220 )
Change subject: cbfstool: Fix possible memory leak
......................................................................
Patch Set 5:
(2 comments)
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/69220/comment/0196b9be_6b410bda
PS4, Line 773: header_offset
Fixed the indent as suggested.
Nothing seems to be changed?
File util/cbfstool/common.c:
https://review.coreboot.org/c/coreboot/+/69220/comment/281f1aa0_c6673df9
PS4, Line 40: }
In line no:30, strdup is using malloc internally to allocate memory for the buffer->name, which has […]
I meant to return -1 *after* line #40, and return 0 in line #42.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69220
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01c4643d1e671d9bd9971ac6db8031634fffd61e
Gerrit-Change-Number: 69220
Gerrit-PatchSet: 5
Gerrit-Owner: Shahina Shaik
shahina.shaik@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shahina Shaik
shahina.shaik@intel.corp-partner.google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Shahina Shaik
shahina.shaik@intel.com
Gerrit-Attention: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Shahina Shaik
shahina.shaik@intel.corp-partner.google.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Mon, 07 Nov 2022 07:57:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shahina Shaik
shahina.shaik@intel.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment