Attention is currently required from: Martin Roth, Marshall Dawson. chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52900 )
Change subject: mb/google/mancomb: Update AMDFW config file ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/mancomb/variants/baseboard/amdfw.cfg:
https://review.coreboot.org/c/coreboot/+/52900/comment/a249307a_2d3138d6 PS1, Line 37: PSP_PMUI_FILE1 TypeId0x65_Appb_CZN_1D_Ddr4_Udimm_Dmem.csbin : PSP_PMUD_FILE2 TypeId0x64_Appb_CZN_2D_Ddr4_Udimm_Imem.csbin
It looks like you transposed the I and D in col. 8, comparing to soc//cezanne. […]
It should like below. PSP_PMUI_FILE1 TypeId0x64_Appb_CZN_1D_Ddr4_Udimm_Imem.csbin PSP_PMUD_FILE1 TypeId0x65_Appb_CZN_1D_Ddr4_Udimm_Dmem.csbin PSP_PMUI_FILE2 TypeId0x64_Appb_CZN_2D_Ddr4_Udimm_Imem.csbin PSP_PMUD_FILE2 TypeId0x65_Appb_CZN_2D_Ddr4_Udimm_Dmem.csbin