Attention is currently required from: Bora Guvendik, Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Kyoung Il Kim, Paul Menzel, Pranava Y N, Subrata Banik, Wonkyu Kim.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85199?usp=email )
Change subject: soc/intel/pantherlake: Add Touch Controller UPD and SoC config
......................................................................
Patch Set 34:
(2 comments)
File src/soc/intel/pantherlake/chip.h:
https://review.coreboot.org/c/coreboot/+/85199/comment/460695e5_bcbbc302?usp... :
PS34, Line 547: 2
Would it make sense to have a `NUM_THC_DEV` (or another name). […]
Done
File src/soc/intel/pantherlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/85199/comment/79784d73_374697a3?usp... :
PS34, Line 578: if (is_devfn_enabled(PCI_DEVFN_THC0)) {
: s_cfg->ThcAssignment[0] = THC_0;
: s_cfg->ThcMode[0] = config->thc_mode[0];
: s_cfg->ThcWakeOnTouch[0] = config->thc_wake_on_touch[0];
: } else {
: s_cfg->ThcAssignment[0] = THC_NONE;
: }
:
: if (is_devfn_enabled(PCI_DEVFN_THC1)) {
: s_cfg->ThcAssignment[1] = THC_1;
: s_cfg->ThcMode[1] = config->thc_mode[1];
: s_cfg->ThcWakeOnTouch[1] = config->thc_wake_on_touch[1];
: } else {
: s_cfg->ThcAssignment[1] = THC_NONE;
: }
What about something like: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85199?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I15fb62eaadc03b9a17e94609b97c686518150e2e
Gerrit-Change-Number: 85199
Gerrit-PatchSet: 34
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Fri, 28 Mar 2025 07:25:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jérémy Compostella
jeremy.compostella@intel.com