Attention is currently required from: Frans Hendriks, Julius Werner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49960 )
Change subject: console/vtxprintf.c: Correct code style
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
I was not aware of the previous discussions about the checkpatch on actual code. […]
Good questions for the mailing list.
IMO, our coding style is not mandatory, so there is no "should"
beside "the code should look good and reasonably similar to our
coding style". Hence, I don't like to bikeshed already merged
code (unless it can be made better without any doubt). And also
not new code if it looks like the author cared to make it
readable. Other people's opinions probably differ.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49960
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb200bf7dd1ef7632aa4e1213bce72d9165560c9
Gerrit-Change-Number: 49960
Gerrit-PatchSet: 2
Gerrit-Owner: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 05 Feb 2021 17:44:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Frans Hendriks
fhendriks@eltan.com
Gerrit-MessageType: comment