Change in coreboot[master]: sb/intel/i82801gx: Fix conversion from 'int' to 'signed char:1'
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37341 ) Change subject: sb/intel/i82801gx: Fix conversion from 'int' to 'signed char:1' ...................................................................... sb/intel/i82801gx: Fix conversion from 'int' to 'signed char:1' Error found using -Wconversion on mainboard/macbook21/static.c Change-Id: I23d7b876f778ab78e922709a0a36f5eec4d60e3d Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> --- M src/southbridge/intel/i82801gx/chip.h 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/37341/1 diff --git a/src/southbridge/intel/i82801gx/chip.h b/src/southbridge/intel/i82801gx/chip.h index 75b9575..f844515 100644 --- a/src/southbridge/intel/i82801gx/chip.h +++ b/src/southbridge/intel/i82801gx/chip.h @@ -76,9 +76,9 @@ /* Enable linear PCIe Root Port function numbers starting at zero */ uint8_t pcie_port_coalesce; - int c4onc3_enable:1; - int docking_supported:1; - int p_cnt_throttling_supported:1; + signed char c4onc3_enable:1; + signed char docking_supported:1; + signed char p_cnt_throttling_supported:1; int c3_latency; /* Additional LPC IO decode ranges */ -- To view, visit https://review.coreboot.org/c/coreboot/+/37341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23d7b876f778ab78e922709a0a36f5eec4d60e3d Gerrit-Change-Number: 37341 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: newchange
Hello Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/37341 to look at the new patch set (#2). Change subject: sb/intel/i82801gx: Fix conversion from 'int' to 'signed char:1' ...................................................................... sb/intel/i82801gx: Fix conversion from 'int' to 'signed char:1' Error found using -Wconversion on mainboard/macbook21/static.c: "error: conversion from 'int' to 'signed char:1' changes value from '1' to '-1'" Change-Id: I23d7b876f778ab78e922709a0a36f5eec4d60e3d Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr> --- M src/southbridge/intel/i82801gx/chip.h 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/37341/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/37341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23d7b876f778ab78e922709a0a36f5eec4d60e3d Gerrit-Change-Number: 37341 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-MessageType: newpatchset
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37341 ) Change subject: sb/intel/i82801gx: Fix conversion from 'int' to 'signed char:1' ...................................................................... Abandoned see 34092 -- To view, visit https://review.coreboot.org/c/coreboot/+/37341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I23d7b876f778ab78e922709a0a36f5eec4d60e3d Gerrit-Change-Number: 37341 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: abandon
participants (1)
-
HAOUAS Elyes (Code Review)