Attention is currently required from: Ravi kumar, Paul Menzel, Ravi Kumar Bokka, mturney mturney, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49392 )
Change subject: sc7280: Add SHRM firmware support
......................................................................
Patch Set 78: Code-Review+2
(1 comment)
File src/soc/qualcomm/sc7280/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49392/comment/8759c7dc_70328e13
PS76, Line 110: none
if i keep CBFS_PRERAM_COMPRESSION flag, device getting crashed at romstage with below error messsage […]
Hmmm....I'm not sure why this happens. Maybe Julius knows?
In the meantime, let's try to get this in w/o compression first and we can do a follow up CL to enable compression once we figure out why the exception is happening.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49392
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44484573a829eaefbd34907c6fe78d427506a762
Gerrit-Change-Number: 49392
Gerrit-PatchSet: 78
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: mturney mturney
mturney@codeaurora.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 07 Oct 2021 09:02:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment