Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45747 )
Change subject: soc/intel/tigerlake: Replace soc_get_pmc_mux_device with device pointers
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45747/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45747/1/src/mainboard/google/voltee...
PS1, Line 403: device ref south_xhci on end
note to self: oops, this should stay
Done
https://review.coreboot.org/c/coreboot/+/45747/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45747/1/src/mainboard/google/voltee...
PS1, Line 183:
: use dev1 as conn1;
C makes it hard not to end lines with semicolons sometimes...
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45747
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie00834c79bd5304998adaccb388ae74a108192b1
Gerrit-Change-Number: 45747
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Oct 2020 15:42:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment