Attention is currently required from: Angel Pons, Arthur Heymans, Cliff Huang, Lance Zhao, Lean Sheng Tan, Maximilian Brune, Naresh Solanki, Patrick Rudolph, Paul Menzel, Tim Wawrzynczak.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78115?usp=email )
Change subject: acpi/acpi_gic: Add GIC ITS subtable
......................................................................
Patch Set 5:
(1 comment)
File src/acpi/acpi_gic.c:
https://review.coreboot.org/c/coreboot/+/78115/comment/68c81f92_248933e5 :
PS5, Line 92: &its_base
It needs a `uintptr_t *` pointing to an array. But that could only
work if you'd know the size in advance...
It seems the code is not even build tested. I suggest to postpone this
review until there is a platform that uses ACPI_COMMON_MADT_GICC_V3.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78115?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1bcb3ad24de64cbba8aeef7ba7254d3157e0dc43
Gerrit-Change-Number: 78115
Gerrit-PatchSet: 5
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Comment-Date: Tue, 28 Nov 2023 13:23:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment