Attention is currently required from: Hung-Te Lin, Shelley Chen, Paul Menzel, Rex-BC Chen, Angel Pons, Yu-Ping Wu.
Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62359 )
Change subject: mb/google/cherry: Pre-initialize PCIe at the bootblock stage
......................................................................
Patch Set 27:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62359/comment/dccae337_389699b5
PS25, Line 13: wait
waiting
Done
https://review.coreboot.org/c/coreboot/+/62359/comment/6e6cb71f_3d8e9a70
PS25, Line 14: assert the pin in bootblock stage
… which is currently the only function of `mtk_pcie_pre_init()`, so …
Done
https://review.coreboot.org/c/coreboot/+/62359/comment/221a205b_5206320a
PS25, Line 15: could be avoided
in romstage (or is it ramstage?) is avoided
Done
File src/mainboard/google/cherry/bootblock.c:
https://review.coreboot.org/c/coreboot/+/62359/comment/20526883_862ba79f
PS25, Line 6: #include <soc/early_init.h>
Do we need to include this?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5b9369e6f8599f93415588ea585c952a41c5e7d
Gerrit-Change-Number: 62359
Gerrit-PatchSet: 27
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 28 Mar 2022 02:27:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment