Attention is currently required from: Ana Carolina Cabral, Fred Reitberger, Jason Glenesk, Matt DeVillier, Paul Menzel.
Felix Held has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/84918?usp=email )
Change subject: soc/amd/common/acpi: Add SPI flash controller
......................................................................
Patch Set 5:
(1 comment)
File src/soc/amd/common/acpi/spi.asl:
https://review.coreboot.org/c/coreboot/+/84918/comment/5c5c9c47_ce8ddb7c?usp... :
PS5, Line 21: ASCE
different values get written to this field from the ASSC method when the driver acquires the bus vs when it releases the bus resulting in different spi chip select pins being used; since the spi flash will always use the same chip select pin, this likely breaks functionality in some case; not sure though which exact case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84918?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0f2c1e3351671ad47fbe5c890e4f99d2e19dbfbf
Gerrit-Change-Number: 84918
Gerrit-PatchSet: 5
Gerrit-Owner: Ana Carolina Cabral
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Ana Carolina Cabral
Gerrit-Comment-Date: Fri, 03 Jan 2025 21:40:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No