Attention is currently required from: Jonathan Zhang, Johnny Lin, Julius Werner, Deomid "rojer" Ryabkov.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51099 )
Change subject: lib/cbfs.c: Fix return value of failure to measure
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51099/comment/d70a4f97_71830073
PS1, Line 10: bootable.
Makes sense. On the other hand, when S-ACM figured out the image is not signed correctly, should coreboot not attempt to measure?
It's the ACM LockConfig call that probably messes up the TPM if the image was not properly set up. It's probably a good idea to skip it if we know it will fail and cause other issues. That way measured boot can work even if CBnT has issues of was inproperly configured.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51099
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd20e543d3b30de045c0656eccdcc494c2fb10ce
Gerrit-Change-Number: 51099
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang
jonzhang@fb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Comment-Date: Fri, 26 Feb 2021 20:28:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment