Change in coreboot[master]: nb/intel/hsw,soc/intel/{bdw,skl,apl},mb/*: unify dt panel settings
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48885 )
Change subject: nb/intel/hsw,soc/intel/{bdw,skl,apl},mb/*: unify dt panel settings ......................................................................
Patch Set 16: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/48885/16/src/mainboard/google/auron... File src/mainboard/google/auron/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48885/16/src/mainboard/google/auron... PS16, Line 16: register "gpu_pch_backlight_pwm_hz" = "200" This is one of the downsides of mixing both PP sequencing and backlight PWM in a single struct. It might just be a matter of time until it falls apart, e.g. when we encounter a chip with different amounts of PP and PWM controls. We'll see how it turns out.
https://review.coreboot.org/c/coreboot/+/48885/16/src/soc/intel/apollolake/c... File src/soc/intel/apollolake/chip.h:
https://review.coreboot.org/c/coreboot/+/48885/16/src/soc/intel/apollolake/c... PS16, Line 40: * the secondary controls. This only applies to the PWM part. Please adapt.
https://review.coreboot.org/c/coreboot/+/48885/16/src/soc/intel/apollolake/g... File src/soc/intel/apollolake/graphics.c:
https://review.coreboot.org/c/coreboot/+/48885/16/src/soc/intel/apollolake/g... PS16, Line 14: const Why ditch the `const`?
-
Nico Huber (Code Review)