[S] Change in coreboot[master]: soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT

[Lean Sheng Tan (Code Review)]

Attention is currently required from: Sean Rhodes.

Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72800 )

Change subject: soc/intel/{tgl,adl}: Hook up D3ColdEnable UPD to D3COLD_SUPPORT
......................................................................

Patch Set 8:

(1 comment)

File src/device/Kconfig:

https://review.coreboot.org/c/coreboot/+/72800/comment/824bf776_0adb5fc3 
PS4, Line 1004: Don't support D3Cold"
              : 	default n if NO_S0IX_SUPPORT
> You were the only one giving +2. […]

1. please check properly for the full log (by clicking show all entries), the build was passed before it was merged. the CI will run again after it was merged, as usual. I did not wait for “random period of time”, as per rules stated at least 24 hours should be waited, and per the whole log this patch was hanging there for more than 2 weeks before it was merged. I am not sure what else you are really looking for here.

2. basically, you jumped in suddenly stating a few things were wrong, and then hastily created a review, even before giving Sean time to respond to it. IMHO that was a bit rude, it’s like saying our patch discussion, review time didn’t matter at all, so let’s undo everything. that is not the right way it should go,