Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19518 )
Change subject: mainboard/google/poppy: Add support for cr50 I2C TPM ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/19518/1/src/mainboard/google/poppy/Kconfig File src/mainboard/google/poppy/Kconfig:
PS1, Line 25: config DRIVER_TPM_I2C_BUS : default 0x1 : : config DRIVER_TPM_I2C_ADDR : default 0x50 :
should these be conditional on POPPY_USE_I2C_TPM being true?
Done
https://review.coreboot.org/#/c/19518/1/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/baseboard/gpio.c:
PS1, Line 95: IS_ENABLED(CONFIG_POPPY_USE_SPI_TPM
aren't USE_SPI_TPM and USE_I2C_TPM mutually exclusive and one of them guara
Right now we have only mocktpm enabled for poppy, so both USE_SPI_TPM and USE_I2C_TPM are not true. That is why I did not combine the two blocks.
-
Furquan Shaikh (Code Review)