Change in coreboot[master]: soc/mediatek/mt8195: Add clk_buf driver

[Rex-BC Chen (Code Review)]

Attention is currently required from: Hung-Te Lin, Xi Chen, Yidi Lin, Yuchen Huang.
Hello Yidi Lin, Yuchen Huang,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/53896

to review the following change.

Change subject: soc/mediatek/mt8195: Add clk_buf driver
......................................................................

soc/mediatek/mt8195: Add clk_buf driver

Both mt8192 and mt8195 use mt6359p clk_buf.
But mt8195 clk_buf uses legacy co-clock mode without srclken_rc.

Signed-off-by: Yuchen Huang 
Change-Id: Ie9ee91449a7a14e77231493f807b321b2dbaa6a6
Signed-off-by: Yidi Lin 
---
M src/mainboard/google/cherry/romstage.c
R src/soc/mediatek/common/clkbuf.c
R src/soc/mediatek/common/include/soc/clkbuf.h
M src/soc/mediatek/mt8192/Makefile.inc
M src/soc/mediatek/mt8195/Makefile.inc
5 files changed, 9 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/53896/1

diff --git a/src/mainboard/google/cherry/romstage.c b/src/mainboard/google/cherry/romstage.c
index cba5995..f4bb1ca 100644
--- a/src/mainboard/google/cherry/romstage.c
+++ b/src/mainboard/google/cherry/romstage.c
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

#include <arch/stages.h>
+#include <soc/clkbuf.h>
 #include <soc/mt6315.h>
 #include <soc/mt6359p.h>
 #include <soc/pmif.h>
@@ -10,4 +11,5 @@
    mtk_pmif_init();
    mt6359p_init();
    mt6315_init();
+	clk_buf_init();
 }
diff --git a/src/soc/mediatek/mt8192/clkbuf.c b/src/soc/mediatek/common/clkbuf.c
similarity index 98%
rename from src/soc/mediatek/mt8192/clkbuf.c
rename to src/soc/mediatek/common/clkbuf.c
index 83fdb92..7354571 100644
--- a/src/soc/mediatek/mt8192/clkbuf.c
+++ b/src/soc/mediatek/common/clkbuf.c
@@ -5,8 +5,9 @@
 #include <device/mmio.h>
 #include <soc/clkbuf.h>
 #include <soc/pmif.h>
+#if CONFIG(SRCLKEN_RC_SUPPORT)
 #include <soc/srclken_rc.h>
-
+#endif

#define BUFTAG			"[CLKBUF]"
 #define buf_info(fmt, arg ...)	printk(BIOS_INFO, BUFTAG "%s,%d: " fmt, \
diff --git a/src/soc/mediatek/mt8192/include/soc/clkbuf.h b/src/soc/mediatek/common/include/soc/clkbuf.h
similarity index 92%
rename from src/soc/mediatek/mt8192/include/soc/clkbuf.h
rename to src/soc/mediatek/common/include/soc/clkbuf.h
index b5fa3a3..d9bad06 100644
--- a/src/soc/mediatek/mt8192/include/soc/clkbuf.h
+++ b/src/soc/mediatek/common/include/soc/clkbuf.h
@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0-only */

-#ifndef SOC_MEDIATEK_MT8192_CLKBUF_H
-#define SOC_MEDIATEK_MT8192_CLKBUF_H
+#ifndef SOC_MEDIATEK_COMMON_CLKBUF_H
+#define SOC_MEDIATEK_COMMON_CLKBUF_H

#include <device/mmio.h>

@@ -66,4 +66,4 @@

int clk_buf_init(void);

-#endif /* SOC_MEDIATEK_MT8192_CLKBUF_H */
+#endif /* SOC_MEDIATEK_COMMON_CLKBUF_H */
diff --git a/src/soc/mediatek/mt8192/Makefile.inc b/src/soc/mediatek/mt8192/Makefile.inc
index e2abc5e..484cfb8 100644
--- a/src/soc/mediatek/mt8192/Makefile.inc
+++ b/src/soc/mediatek/mt8192/Makefile.inc
@@ -23,7 +23,7 @@

romstage-y += ../common/auxadc.c
 romstage-y += ../common/cbmem.c
-romstage-y += clkbuf.c srclken_rc.c
+romstage-y += ../common/clkbuf.c srclken_rc.c
 romstage-y += ../common/dram_init.c
 romstage-y += ../common/dramc_param.c
 romstage-y += ../common/flash_controller.c
diff --git a/src/soc/mediatek/mt8195/Makefile.inc b/src/soc/mediatek/mt8195/Makefile.inc
index c344849..cc855b2 100644
--- a/src/soc/mediatek/mt8195/Makefile.inc
+++ b/src/soc/mediatek/mt8195/Makefile.inc
@@ -20,6 +20,7 @@
 verstage-y += ../common/wdt.c

romstage-y += ../common/cbmem.c
+romstage-y += ../common/clkbuf.c
 romstage-y += emi.c
 romstage-y += ../common/flash_controller.c
 romstage-y += ../common/gpio.c gpio.c