Attention is currently required from: Mathew King. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51069 )
Change subject: mb/google/guybrush: Add option to toggle GPIO for sign of life ......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/bootblock.c:
https://review.coreboot.org/c/coreboot/+/51069/comment/889169cb_e298d813 PS3, Line 17: struct soc_amd_gpio sol = PAD_GPO(GPIO_31, LOW); This uses a lot more code than we need. Why not just set it to GPO LOW in the program_gpios call above, then use gpio_set in the loop?
gpio_set(GPIO_31, 1)