Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel, Shawn Ku, Subrata Banik.
Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79724?usp=email )
Change subject: mb/google/nissa/var/quandiso: Tune P-sensors for Linux 5.15 sx9324 driver
......................................................................
Patch Set 5:
(2 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/79724/comment/d7f98040_23815403 :
PS3, Line 9: Update proximity sensor tuning value from SX9324ICSTRT schematic.
Please update the commit message accordingly.
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/79724/comment/de1dda20_69c4b497 :
PS4, Line 12: nissa,need
Please add a space after the comma.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79724?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5fc3bc5876594f2df79d628bd986113d37087c3d
Gerrit-Change-Number: 79724
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shawn Ku
shawnku@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 05 Jan 2024 07:53:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-MessageType: comment